steffen/website
1
0
Fork 0
Code Actions Packages Releases Activity

Fix site.logo false positives

Browse Source
This commit is contained in:
Michael Rose 2019-01-23 20:05:17 -05:00
parent f405d24ce2
commit d41a284bd2
3 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -2,6 +2,7 @@
### Bug Fixes ### Bug Fixes
- Fix `site.logo` false positives. [#2026](https://github.com/mmistakes/minimal-mistakes/pull/2026#issuecomment-455770730)
- Add empty `alt` attribute to `site.logo` image. [#2035](https://github.com/mmistakes/minimal-mistakes/pull/2035) - Add empty `alt` attribute to `site.logo` image. [#2035](https://github.com/mmistakes/minimal-mistakes/pull/2035)
## [4.15.1](https://github.com/mmistakes/minimal-mistakes/releases/tag/4.15.1) ## [4.15.1](https://github.com/mmistakes/minimal-mistakes/releases/tag/4.15.1)

6
_includes/masthead.html
View File

@ -1,14 +1,16 @@
{% if site.logo contains "://" %} {% if site.logo contains "://" %}
{% capture logo_path %}{{ site.logo }}{% endcapture %} {% capture logo_path %}{{ site.logo }}{% endcapture %}
{% else %} {% else %}
{% capture logo_path %}{{ site.logo | relative_url }}{% endcapture %} {% capture logo_path %}{{ site.logo }}{% endcapture %}
{% endif %} {% endif %}
<div class="masthead"> <div class="masthead">
<div class="masthead__inner-wrap"> <div class="masthead__inner-wrap">
<div class="masthead__menu"> <div class="masthead__menu">
<nav id="site-nav" class="greedy-nav"> <nav id="site-nav" class="greedy-nav">
{% if site.logo %}<a class="site-logo" href="{{ '/' | relative_url }}"><img src="{{ logo_path }}" alt=""></a>{% endif %} {% unless logo_path == empty %}
<a class="site-logo" href="{{ '/' | relative_url }}"><img src="{{ logo_path | relative_url }}" alt=""></a>
{% endunless %}
<a class="site-title" href="{{ '/' | relative_url }}">{{ site.masthead_title | default: site.title }}</a> <a class="site-title" href="{{ '/' | relative_url }}">{{ site.masthead_title | default: site.title }}</a>
<ul class="visible-links"> <ul class="visible-links">
{%- for link in site.data.navigation.main -%} {%- for link in site.data.navigation.main -%}

3
docs/_docs/18-history.md
View File

@ -4,7 +4,7 @@ permalink: /docs/history/
excerpt: "Change log of enhancements and bug fixes made to the theme." excerpt: "Change log of enhancements and bug fixes made to the theme."
sidebar: sidebar:
nav: docs nav: docs
last_modified_at: 2019-01-23T19:35:45-05:00 last_modified_at: 2019-01-23T20:04:54-05:00
toc: true toc: true
--- ---
@ -12,6 +12,7 @@ toc: true
### Bug Fixes ### Bug Fixes
- Fix `site.logo` false positives. [#2026](https://github.com/mmistakes/minimal-mistakes/pull/2026#issuecomment-455770730)
- Add empty `alt` attribute to `site.logo` image. [#2035](https://github.com/mmistakes/minimal-mistakes/pull/2035) - Add empty `alt` attribute to `site.logo` image. [#2035](https://github.com/mmistakes/minimal-mistakes/pull/2035)
## [4.15.1](https://github.com/mmistakes/minimal-mistakes/releases/tag/4.15.1) ## [4.15.1](https://github.com/mmistakes/minimal-mistakes/releases/tag/4.15.1)