From 3e0527fa78c1322186299944b5bb1348bd7a3143 Mon Sep 17 00:00:00 2001
From: Michael Rose <est.michael@gmail.com>
Date: Mon, 18 Apr 2016 16:22:53 -0400
Subject: [PATCH] Improve nav_list helper to be used with any type of
 navigation list defined in navigation.yml data file - Close #272

---
 _includes/nav_list     | 35 +++++++++++++++++++++++++++++------
 _includes/sidebar.html |  2 +-
 2 files changed, 30 insertions(+), 7 deletions(-)

diff --git a/_includes/nav_list b/_includes/nav_list
index 352856f7..60399880 100644
--- a/_includes/nav_list
+++ b/_includes/nav_list
@@ -1,25 +1,48 @@
 {% include base_path %}
-{% assign navigation = site.data.navigation[page.sidebar.nav] %}
+{% assign navigation = site.data.navigation[include.nav] %}
 
 <nav class="nav__list">
   {% if page.sidebar.title %}<header><h4 class="nav__title" style="padding: 0;">{{ page.sidebar.title }}</h4></header>{% endif %}
   <ul>
     {% for nav in navigation %}
-      <li><span class="nav__sub-title">{{ nav.title }}</span>
+      <li>
+        {% if nav.url %}
+          {% comment %}internal/external URL check{% endcomment %}
+          {% if nav.url contains "http" %}
+            {% assign domain = "" %}
+          {% else %}
+            {% assign domain = base_path %}
+          {% endif %}
+
+          <a href="{{ domain }}{{ nav.url }}"><span class="nav__sub-title">{{ nav.title }}</span></a>
+        {% else %}
+          <span class="nav__sub-title">{{ nav.title }}</span>
+        {% endif %}
+
         {% if nav.children != null %}
         <ul>
           {% for child in nav.children %}
-          {% assign nav_url = child.path | prepend: "/" | prepend: page.sidebar.nav | prepend: "/" | append: "/" %}
-            {% if nav_url == page.url %}
+            {% comment %}internal/external URL check{% endcomment %}
+            {% if child.url contains "http" %}
+              {% assign domain = "" %}
+            {% else %}
+              {% assign domain = base_path %}
+            {% endif %}
+
+            {% comment %}set "active" class on current page{% endcomment %}
+            {% if child.url == page.url %}
               {% assign active = "active" %}
             {% else %}
               {% assign active = "" %}
             {% endif %}
-            <li><a href="{{ nav_url | prepend: base_path }}" class="{{ active }}">{{ child.title }}</a></li>
+
+            <li><a href="{{ domain }}{{ child.url }}" class="{{ active }}">{{ child.title }}</a></li>
           {% endfor %}
         </ul>
         {% endif %}
       </li>
     {% endfor %}
   </ul>
-</nav>
\ No newline at end of file
+</nav>
+
+
diff --git a/_includes/sidebar.html b/_includes/sidebar.html
index 072ffca7..dbb7aae4 100644
--- a/_includes/sidebar.html
+++ b/_includes/sidebar.html
@@ -18,7 +18,7 @@
       {% if s.text %}{{ s.text | markdownify }}{% endif %}
     {% endfor %}
     {% if page.sidebar.nav %}
-      {% include nav_list items=page.sidebar.nav %}
+      {% include nav_list nav=page.sidebar.nav %}
     {% endif %}
   {% endif %}
   </div>