Resolved some warnings and style issues

marl_factory_grid/modules/maintenance/constants.py

@@ -1,3 +1,4 @@
 MAINTAINER         = 'Maintainer'                    # TEMPLATE _identifier. Define your own!
 MAINTAINERS        = 'Maintainers'                   # TEMPLATE _identifier. Define your own!
 
+MAINTAINER_COLLISION_REWARD = -5

marl_factory_grid/modules/maintenance/groups.py

@@ -4,7 +4,6 @@ from marl_factory_grid.environment.groups.collection import Collection
 from .entities import Maintainer
 from ..machines import constants as mc
 from ..machines.actions import MachineAction
-from ...utils.states import Gamestate
 
 
 class Maintainers(Collection):
@@ -23,8 +22,6 @@ class Maintainers(Collection):
         self.size = size
         self._spawnrule = spawnrule
 
-    def __init__(self, *args, **kwargs):
-        super().__init__(*args, **kwargs)
 
     def spawn(self, coords_or_quantity: Union[int, List[Tuple[(int, int)]]], *entity_args):
         self.add_items([self._entity(mc.MACHINES, MachineAction(), pos) for pos in coords_or_quantity])

marl_factory_grid/modules/maintenance/rewards.py

@@ -1 +0,0 @@
-MAINTAINER_COLLISION_REWARD = -5

marl_factory_grid/modules/maintenance/rules.py

@@ -1,15 +1,16 @@
 from typing import List
+
+import marl_factory_grid.modules.maintenance.constants
 from marl_factory_grid.environment.rules import Rule
 from marl_factory_grid.utils.results import TickResult, DoneResult
 from marl_factory_grid.environment import constants as c
-from . import rewards as r
 from . import constants as M
 
 
 class MoveMaintainers(Rule):
 
-    def __init__(self, *args, **kwargs):
-        super().__init__(*args, **kwargs)
+    def __init__(self):
+        super().__init__()
 
     def tick_step(self, state) -> List[TickResult]:
         for maintainer in state[M.MAINTAINERS]:
@@ -20,8 +21,8 @@ class MoveMaintainers(Rule):
 
 class DoneAtMaintainerCollision(Rule):
 
-    def __init__(self, *args, **kwargs):
-        super().__init__(*args, **kwargs)
+    def __init__(self):
+        super().__init__()
 
     def on_check_done(self, state) -> List[DoneResult]:
         agents = list(state[c.AGENT].values())
@@ -30,5 +31,5 @@ class DoneAtMaintainerCollision(Rule):
         for agent in agents:
             if agent.pos in m_pos:
                 done_results.append(DoneResult(entity=agent, validity=c.VALID, identifier=self.name,
-                                               reward=r.MAINTAINER_COLLISION_REWARD))
+                                               reward=marl_factory_grid.modules.maintenance.constants.MAINTAINER_COLLISION_REWARD))
         return done_results