mirror of
https://github.com/illiumst/marl-factory-grid.git
synced 2025-09-13 22:44:00 +02:00
Resolved some warnings and style issues
This commit is contained in:
@@ -1,9 +1,10 @@
|
||||
from typing import Union
|
||||
|
||||
import marl_factory_grid.modules.machines.constants
|
||||
from marl_factory_grid.environment.actions import Action
|
||||
from marl_factory_grid.utils.results import ActionResult
|
||||
|
||||
from marl_factory_grid.modules.machines import constants as m, rewards as r
|
||||
from marl_factory_grid.modules.machines import constants as m
|
||||
from marl_factory_grid.environment import constants as c
|
||||
from marl_factory_grid.utils import helpers as h
|
||||
|
||||
@@ -16,8 +17,10 @@ class MachineAction(Action):
|
||||
def do(self, entity, state) -> Union[None, ActionResult]:
|
||||
if machine := h.get_first(state[m.MACHINES].by_pos(entity.pos)):
|
||||
if valid := machine.maintain():
|
||||
return ActionResult(entity=entity, identifier=self._identifier, validity=valid, reward=r.MAINTAIN_VALID)
|
||||
return ActionResult(entity=entity, identifier=self._identifier, validity=valid, reward=marl_factory_grid.modules.machines.constants.MAINTAIN_VALID)
|
||||
else:
|
||||
return ActionResult(entity=entity, identifier=self._identifier, validity=valid, reward=r.MAINTAIN_FAIL)
|
||||
return ActionResult(entity=entity, identifier=self._identifier, validity=valid, reward=marl_factory_grid.modules.machines.constants.MAINTAIN_FAIL)
|
||||
else:
|
||||
return ActionResult(entity=entity, identifier=self._identifier, validity=c.NOT_VALID, reward=r.MAINTAIN_FAIL)
|
||||
return ActionResult(entity=entity, identifier=self._identifier,
|
||||
validity=c.NOT_VALID, reward=marl_factory_grid.modules.machines.constants.MAINTAIN_FAIL
|
||||
)
|
||||
|
@@ -11,3 +11,7 @@ STATE_MAINTAIN = 'maintenance'
|
||||
SYMBOL_WORK = 1
|
||||
SYMBOL_IDLE = 0.6
|
||||
SYMBOL_MAINTAIN = 0.3
|
||||
MAINTAIN_VALID: float = 0.5
|
||||
MAINTAIN_FAIL: float = -0.1
|
||||
FAIL_MISSING_MAINTENANCE: float = -0.5
|
||||
NONE: float = 0
|
||||
|
@@ -31,11 +31,10 @@ class Machine(Entity):
|
||||
return c.NOT_VALID
|
||||
|
||||
def tick(self, state):
|
||||
# if self.status == m.STATE_MAINTAIN and any([c.AGENT in x.name for x in self.tile.guests]):
|
||||
if self.status == m.STATE_MAINTAIN and any([c.AGENT in x.name for x in state.entities.pos_dict[self.pos]]):
|
||||
others = state.entities.pos_dict[self.pos]
|
||||
if self.status == m.STATE_MAINTAIN and any([c.AGENT in x.name for x in others]):
|
||||
return TickResult(identifier=self.name, validity=c.VALID, entity=self)
|
||||
# elif self.status == m.STATE_MAINTAIN and not any([c.AGENT in x.name for x in self.tile.guests]):
|
||||
elif self.status == m.STATE_MAINTAIN and not any([c.AGENT in x.name for x in state.entities.pos_dict[self.pos]]):
|
||||
elif self.status == m.STATE_MAINTAIN and not any([c.AGENT in x.name for x in others]):
|
||||
self.status = m.STATE_WORK
|
||||
self.reset_counter()
|
||||
return None
|
||||
|
@@ -1,5 +1,3 @@
|
||||
from typing import Union, List, Tuple
|
||||
|
||||
from marl_factory_grid.environment.groups.collection import Collection
|
||||
|
||||
from .entitites import Machine
|
||||
|
@@ -1,5 +0,0 @@
|
||||
MAINTAIN_VALID: float = 0.5
|
||||
MAINTAIN_FAIL: float = -0.1
|
||||
FAIL_MISSING_MAINTENANCE: float = -0.5
|
||||
|
||||
NONE: float = 0
|
Reference in New Issue
Block a user