Resolved some warnings and style issues

marl_factory_grid/modules/items/constants.py

@@ -1,6 +1,3 @@
-from typing import NamedTuple
-
-
 SYMBOL_NO_ITEM      = 0
 SYMBOL_DROP_OFF     = 1
 # Item Env

marl_factory_grid/modules/items/entitites.py

@@ -14,27 +14,14 @@ class Item(Entity):
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
 
-    @property
-    def auto_despawn(self):
-        return self._auto_despawn
-
     @property
     def encoding(self):
         # Edit this if you want items to be drawn in the ops differently
         return 1
 
-    def set_auto_despawn(self, auto_despawn):
-        self._auto_despawn = auto_despawn
-
-    def summarize_state(self) -> dict:
-        super_summarization = super(Item, self).summarize_state()
-        super_summarization.update(dict(auto_despawn=self.auto_despawn))
-        return super_summarization
-
 
 class DropOffLocation(Entity):
 
-
     def render(self):
         return RenderEntity(i.DROP_OFF, self.pos)
 
@@ -42,18 +29,16 @@ class DropOffLocation(Entity):
     def encoding(self):
         return i.SYMBOL_DROP_OFF
 
-    def __init__(self, *args, storage_size_until_full: int = 5, auto_item_despawn_interval: int = 5, **kwargs):
+    def __init__(self, *args, storage_size_until_full: int = 5, **kwargs):
         super(DropOffLocation, self).__init__(*args, **kwargs)
-        self.auto_item_despawn_interval = auto_item_despawn_interval
         self.storage = deque(maxlen=storage_size_until_full or None)
 
     def place_item(self, item: Item):
         if self.is_full:
             raise RuntimeWarning("There is currently no way to clear the storage or make it unfull.")
-            return bc.NOT_VALID  # in Zeile 81 verschieben?
+            return bc.NOT_VALID
         else:
             self.storage.append(item)
-            item.set_auto_despawn(self.auto_item_despawn_interval)
             return c.VALID
 
     @property

marl_factory_grid/modules/items/groups.py

@@ -1,12 +1,9 @@
-from random import shuffle
-
-from marl_factory_grid.modules.items import constants as i
 from marl_factory_grid.environment import constants as c
-
-from marl_factory_grid.environment.groups.collection import Collection
-from marl_factory_grid.environment.groups.objects import _Objects
-from marl_factory_grid.environment.groups.mixins import IsBoundMixin
 from marl_factory_grid.environment.entity.agent import Agent
+from marl_factory_grid.environment.groups.collection import Collection
+from marl_factory_grid.environment.groups.mixins import IsBoundMixin
+from marl_factory_grid.environment.groups.objects import Objects
+from marl_factory_grid.modules.items import constants as i
 from marl_factory_grid.modules.items.entitites import Item, DropOffLocation
 from marl_factory_grid.utils.results import Result
 
@@ -74,13 +71,12 @@ class Inventory(IsBoundMixin, Collection):
         self._collection = collection
 
 
-class Inventories(_Objects):
+class Inventories(Objects):
     _entity = Inventory
 
     var_can_move = False
     var_has_position = False
 
-
     symbol = None
 
     @property
@@ -116,7 +112,6 @@ class Inventories(_Objects):
         return [val.summarize_states(**kwargs) for key, val in self.items()]
 
 
-
 class DropOffLocations(Collection):
     _entity = DropOffLocation
 

marl_factory_grid/modules/items/rewards.py

@@ -1,4 +1,4 @@
 DROP_OFF_VALID: float = 0.1
 DROP_OFF_FAIL: float = -0.1
 PICK_UP_FAIL: float = -0.1
-PICK_UP_VALID: float = 0.1
+PICK_UP_VALID: float = 0.1